• 18 Posts
  • 120 Comments
Joined 2 years ago
cake
Cake day: June 12th, 2023

help-circle

  • There are a few things I don’t like about this scoring system :

    • Why is there a “Top Provider Content Share” metric if its gonna score the same as the “Top Provider User Share” every time ?
    • Why is the Top Provider Content Share not higher than the user share ? For instance, emails usually have at least one sender and one recipient, making it twice as likely that at least one of them is using gmail. If an email has 10 recipients across 10 different providers, each provider has a copy of the data
    • Why is ease of hosting a mail server rated so well ? How is “leveraging email hosting services” decentralized in any way ?
    • Why are we using a random repo created a few hours ago by a random github user as a reference ?

  • There are a few things I don’t like about this scoring system :

    • Why is there a “Top Provider Content Share” metric if its gonna score the same as the “Top Provider User Share” every time ?
    • Why is the Top Provider Content Share not higher than the user share ? For instance, emails usually have at least one sender and one recipient, making it twice as likely that at least one of them is using gmail. If an email has 10 recipients across 10 different providers, each provider has a copy of the data
    • Why is ease of hosting a mail server rated so well ? How is “leveraging email hosting services” decentralized in any way ?
    • Why are we using a random repo created a few hours ago by a random github user as a reference ?













  • Well it’s in the name, they are code smells, not hard rules.

    Regarding the specific example you cited, I think that with practice it becomes gradually more natural to write reusable functions and methods on the first iteration, removing the need for later DRY-related refactorings.

    PS : I love how your quote for the Rule of Three is getting syntax highlighted xD (You can use markdown quotes by starting quoted lines with > )





  • That’s not what I said. I said that comments can often (but not always) be replaced with good and explicit names.

    This can be pushed to some extreme by making functions that only get called at a single place in the code, just for the sake of being able to give a name to the code that’s inside (instead of inlining it and adding a comment that conveys the same informations as the function’s signature)

    It’s definetly not for everyone, but for beginners/juniors it gives something objective they can aim for when trying to build good coding habits